Append the output of grad_transform_on_trace to computation_traces - #2392
Merged
Merged
Conversation
crcrpar
force-pushed
the
crcrpar-patch-3
branch
from
August 6, 2025 05:04
d571548 to
1444191
Compare
It'd be reasonable to append the output of `grad_transform_on_trace` to `computation_traces: list[TraceCtx]`
crcrpar
force-pushed
the
crcrpar-patch-3
branch
from
August 26, 2025 15:33
1444191 to
7a972fd
Compare
t-vi
approved these changes
Aug 27, 2025
t-vi
enabled auto-merge (squash)
August 27, 2025 08:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It'd be reasonable to append the output of
grad_transform_on_tracetocomputation_traces: list[TraceCtx]